[Bug #21623] Consistently reject endless method definitions without argument parens #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a endless method is started with `=`, there was ambiguity here. We have to simply reject these in all cases. This adds a new error for the following reason: * `def foo arg = nil` is interpreted as a normal method call with optional `arg` without matching `end` * `def foo *arg = nil; end` is interpreted as a endless method call that has body `nil` with extraneous `end` `def foo *arg = nil` is somewhere inbetween and I don't know how to otherwise indicate the error. Now the second case above also shows the newly added error message. Fixes [Bug #21623]
Member
|
I'm not sure if it's related to this fix, perhaps a separate issue, but |
Earlopain
added a commit
to Earlopain/prism
that referenced
this pull request
Nov 1, 2025
Fixes [#Bug 21660], followup to ruby#3674
Earlopain
added a commit
to Earlopain/prism
that referenced
this pull request
Nov 1, 2025
Fixes [#Bug 21660], followup to ruby#3674 Co-Authored-By: tomoya ishida <[email protected]>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 6, 2025
Fixes [#Bug 21660], followup to ruby/prism#3674 ruby/prism@fb445a49e5 Co-Authored-By: tomoya ishida <[email protected]>
stevenjohnstone
pushed a commit
to stevenjohnstone/prism
that referenced
this pull request
Nov 10, 2025
Fixes [#Bug 21660], followup to ruby#3674 Co-Authored-By: tomoya ishida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these special cases, there exists no optional argument type. Since a endless method is started with
=, there was ambiguity here. We have to simply reject these in all cases.This adds a new error for the following reason:
def foo arg = nilis interpreted as a normal method call with optionalargwithout matchingenddef foo *arg = nil; endis interpreted as a endless method call that has bodynilwith extraneousenddef foo *arg = nilis somewhere inbetween and I don't know how to otherwise indicate the error.Now the second case above also shows the newly added error message.
Fixes [Bug #21623]