-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BN#mod_sqrt #553
Add BN#mod_sqrt #553
Conversation
BN_mod_sqrt() has a different function signature. https://github.com/ruby/openssl/actions/runs/3260413057/jobs/5353954966#step:6:88
|
Whoops. Sorry about that. The signature matches |
* bn.mod_sqrt(bn2) => aBN | ||
*/ | ||
BIGNUM_2cr(mod_sqrt) | ||
|
||
/* | ||
* call-seq: | ||
* bn.mod_inverse(bn2) => aBN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need a Document-method:
to tell rdoc about this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 5befde7
Yes, that makes sense! |
Merged, thanks! |
This PR adds support for
BN_mod_sqrt
asBN#mod_sqrt
.