Fix OpenSSL::PKey::RSA#private?, export, to_der when private exp not set #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR is related https://bugs.ruby-lang.org/issues/15841 .
When key is not set private exponent(=
d
),OpenSSL::PKey::RSA#private?
returnstrue
. It should returnfalse
.OpenSSL::PKey::RSA#export
returns PEM string withRSA PRIVATE KEY
header. It should return public key PEM.OpenSSL::PKey::RSA#to_der
returns neither public key format nor private key format string. It should return either.OpenSSL::PKey::RSA#{en,de}crypt
raises segfaults. It is fixed by Fix segfaults in OpenSSL::PKey::RSA#private_{en,de}crypt when private exp not set #255 .For example:
This PR fixes
RSA_HAS_PRIVATE
to check that bothe
andd
are not NULL andRSA#export
andRSA#to_der
to check key, factors and crt_params.