Skip to content

Conversation

jeremyevans
Copy link
Contributor

This approach will handle the Set-Cookie header during the redirect.
To avoid redirect loops for arbitrary cookies and the same URI,
it will not redirect to an URI more than once for the cookie/non-cookie
cases.

Implements Ruby Feature #11322

This approach will handle the Set-Cookie header during the redirect.
To avoid redirect loops for arbitrary cookies and the same URI,
it will not redirect to an URI more than once for the cookie/non-cookie
cases.

Implements Ruby Feature #11322
@jeremyevans jeremyevans requested a review from akr November 13, 2020 03:53
@hsbt
Copy link
Member

hsbt commented Nov 9, 2023

@jeremyevans How do you feel explicitly specified redirect limit at #18 ?

I felt #18 is better because there is no breaking change rather than this.

@jeremyevans
Copy link
Contributor Author

I think the changes are orthogonal. Supporting a max limit of redirects as in #18 seems like a good idea. However, redirects that set cookies and rely on the cookies being submitted in future requests will still be broken without this, so I still think this is a good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants