Support to become bundled gems #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
support-bundled-gems
branch
3 times, most recently
from
4621018 to
9cb9f1c
Compare
olleolleolle
reviewed
Jan 9, 2025
test/logger/test_logdevice.rb
Outdated
| @@ -848,7 +849,7 @@ class << Time | |||
| def run_children(n, args, src) | |||
| r, w = IO.pipe | |||
| [w, *(1..n).map do | |||
| f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -rlogger -], *args], "w", err: w) | |||
| f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -I#{@top_lovel} -rlogger -], *args], "w", err: w) | |||
There was a problem hiding this comment.
Perhaps this?
Suggested change
| f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -I#{@top_lovel} -rlogger -], *args], "w", err: w) | |
| f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -I#{@top_dir} -rlogger -], *args], "w", err: w) |
There was a problem hiding this comment.
👍 It's totally top_level's typo.
hsbt
force-pushed
the
support-bundled-gems
branch
from
9cb9f1c to
a203879
Compare
hsbt
changed the title
hsbt
force-pushed
the
support-bundled-gems
branch
from
5810a76 to
fba3ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ruby/ruby#12537