Proposal to ship the JSON gem with precompiled binaries #907
+100
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hello, sorry if I should have created an issue first, wasn't sure where to propose this.
TL;DR I'd like to propose releasing the json gem with precompiled binaries built for different platforms and different ABI version (fat gem).
I'm currently working on a tool to help the Ruby community ship gems with precompiled binaries with the intent to make
bundle installmuch faster for everyone. The main bottleneck when installing gems in a project is the compilation of native extensions.After testing internally and with private gems, I'd like to get the feedback of a few gem maintainers.
What is it
cibuildgem modestly tries to follow the same approach as cibuildwheel from the python community. It works by compiling natively using CI runners (GitHub it the only supported vendor for now) and tries to be as easy to setup as possible. The json gem already relies on Rake Compiler for development purposes, and because cibuildgem piggyback on top of Rake Compiler, there is no extra configuration required.
The CI workflow in this commit was generated with the cibuildgem CLI which reads the gemspec and determine what ruby versions needs to be compiled and tested against. This is the resulting CI when this workflow runs: https://github.com/Shopify/json-1/actions/runs/19836110651
The tool is very new and I did many tests internally to make sure that it create binaries that can be used in other environments. For instance, I used it to precompile almost all gems that a new Rails application depends on and pushed them under a different "namespace" on my RubyGems, I then confirmed that the rails application was bootable using all those gems (I'm on MacOS).
I was hoping I could use the json gem and get the feedback of its maintainers in order to continue the development of cibuildgem and improve it.
Things you may want to know
On GitHub, the earliest glibc version we can use is 2.35 (using Ubuntu 22). This means that any users that are on a linux distro that comes with a glibc version lower than this will not be able to install the gem with precompiled binaries. They'll have to install the "normal" gem and specify it in their gemfile
(
gem 'json', platform: 'ruby').This workflow gets triggered manually through the GitHub action page when you are ready to cut a release. You can optionally decide to let the tool do the release on RubyGems (using a chechbox on the GitHub UI). If you'd prefer doing it from your machine, you can download the gems from the GitHub action artifacts.
The workflow in this commit compile binaries for MacOS silicon and linux x86_64. It should work on windows but I have not tested extensively to be confident. You should also be able to use macos intel and linus arm64 (GitHub started to offer this recently).
If you have any questions, I'm happy to answer! Any feedback would be amazing so feel free to point anything that you'd like to see this tool do or not do 😅 .