Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn json_pure into an empty gem #685

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Turn json_pure into an empty gem #685

merged 1 commit into from
Nov 5, 2024

Conversation

casperisfine
Copy link

Fix: #650
Closes: #682

cc @eregon @Earlopain

@casperisfine casperisfine force-pushed the json-pure-shim branch 4 times, most recently from 2aa773e to 6fdcacb Compare November 5, 2024 15:00
@byroot byroot merged commit fa05b14 into ruby:master Nov 5, 2024
36 checks passed
@eregon
Copy link
Member

eregon commented Nov 5, 2024

I didn't realize this would mean removing lib/json/pure/parser.rb but I think it makes sense, no point to maintain another backend if it's not used in any case.

We could have kept require 'json/pure' to require the pure generator & parser, but I suppose there is very limited value/use cases for that.

jamescook added a commit to jamescook/chargebee-ruby that referenced this pull request Dec 18, 2024
@jamescook
Remove json-pure gem
0a14391 
This is unused. Also, this gem is now an "empty gem":

ruby/json#685
@jamescook jamescook mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out what to do when different versions of json and json_pure are loaded
3 participants
@casperisfine @eregon @byroot