Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise JSON::GeneratorError instead of Encoding::UndefinedConversionError #683

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Raise JSON::GeneratorError instead of Encoding::UndefinedConversionError #683

merged 1 commit into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. Raise JSON::GeneratorError instead of Encoding::UndefinedConversionError 

    Followup: ruby#633

That's what was raised historically. You could argue that this new
exception is more precise, but I've encountered some real production
code that expected the old behavior and that was broken by this change.
    @byroot
    byroot committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1c44851 View commit details
    Browse the repository at this point in the history