Remove references to "19" methods in JRuby #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods have been deprecated for some time and we would like to delete them. See jruby/jruby#9143 and jruby/jruby#8149.
headius
force-pushed
the
no_19_jruby_methods
branch
from
818d935
to
a480682
Compare
|
The |
|
This appears to be passing on all JRuby versions back to 9.1, and can be released any time. We will want this in the wild for a while before we can proceed with removing the 19 versions, which mostly will happen in JRuby 10 (later this year) and a subsequent major release. |
|
@hsbt Thank you for merging! We can release this any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods have been deprecated for some time and we would like to delete them.
See jruby/jruby#9143 and jruby/jruby#8149.