Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truffleruby tests by upgrading truffleruby #48

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

skipkayhil
Copy link
Contributor

The current combination of truffleruby 21.3.0 and ubuntu 22.04 does not exist as a published truffleruby binary. This previously worked because ubuntu-latest was 20.04, which does have a release published for truffleruby 21.3.0

See https://github.com/ruby/ruby-builder/releases/tag/toolcache for the full list of binaries

The current combination of truffleruby 21.3.0 and ubuntu 22.04 does not
exist as a published truffleruby binary. This previously worked because
ubuntu-latest was 20.04, which does have a release published for
truffleruby 21.3.0
@olleolleolle
Copy link
Contributor

olleolleolle commented Dec 16, 2022

First, 🎉, this is super, and gets us to green. Thank you, @skipkayhil!

Thinking 🤔 : Is this the case for many other ruby/ library repos, as well?

@hsbt
Copy link
Member

hsbt commented Dec 18, 2022

We try to build re-usable steps for all supported versions/platforms at https://github.com/ruby/drb/blob/master/.github/workflows/test.yml#L14.

I have a plan to extract this to independent actions after releasing Ruby 3.2.

@amatsuda
Copy link
Member

amatsuda commented Jan 6, 2023

Let me merge this anyway, in order to make sure that none of my PRs are breaking the build.

@amatsuda amatsuda merged commit 33d2d14 into ruby:master Jan 6, 2023
@skipkayhil skipkayhil deleted the fix-truffleruby-test branch January 6, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants