Upgrade test matrix #739
Merged
Upgrade test matrix #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstc
reviewed
Aug 15, 2023
noelrappin
commented
Aug 16, 2023
| @@ -15,6 +15,6 @@ end | |||
|
|
|||
| group :development do | |||
| gem 'appraisal', git: 'https://github.com/thoughtbot/appraisal.git' | |||
| gem 'pry-byebug', '3.9.0' | |||
| gem 'pry-byebug' | |||
There was a problem hiding this comment.
Needed to unpin pry-byebug to let it find the right version for each Ruby version
phstc
approved these changes
Aug 16, 2023
phstc
reviewed
Aug 16, 2023
| gem "appraisal", git: "https://github.com/thoughtbot/appraisal.git" | ||
| gem "rubocop" | ||
| gem "pry", ">= 0.14.2" | ||
| gem "pry-byebug", ">= 3.10.1" |
There was a problem hiding this comment.
Needed to unpin pry-byebug to let it find the right version for each Ruby version
@noelrappin Just double-checking, for rails 7_0, you need to pint it, right?
There was a problem hiding this comment.
You need a minimum, but it'd probably find it on it's own, really. It's much less of an issue in the Rails specs since each one is different, then the Ruby specs, that share a gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade test matrix to include Ruby 3.1, Ruby 3.2 and Rails 7