Memoize Shoryuken::Queue#visibility_timeout to avoid hitting SQS API multiple times #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2018 19:19
ghost
changed the title
phstc
reviewed
Nov 6, 2018
| @@ -14,7 +14,7 @@ def initialize(client, name_or_url) | |||
| end | |||
|
|
|||
| def visibility_timeout | |||
| queue_attributes.attributes[VISIBILITY_TIMEOUT_ATTR].to_i | |||
| @visibility_timeout ||= queue_attributes.attributes[VISIBILITY_TIMEOUT_ATTR].to_i | |||
There was a problem hiding this comment.
Hi @julien-unitylab
For FIFO, it is easy to merge the memoization (#529), since a FIFO queue can't be changed to a standard queue, so that value once it is loaded, won't change.
But for the visibility timeout, it can change. If we memoize it, Shoryuken processes will need to be restarted to catch up with the changes.
I'm wondering if this could be an option in the shoryuken.yml#cache_visibility_timeout (default to false for not introducing break changes).
WDYT?
There was a problem hiding this comment.
Hey @julien-unitylab
Did you have a chance to check that ☝️
There was a problem hiding this comment.
I created another PR with the proposed fix #533
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some memoization on Shoryuken::Queue#visibility_timeout to avoid hitting SQS API multiple times.