Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fetcher, polling strategy and manager #284

Merged
merged 11 commits into from
Dec 13, 2016
Merged

Refactor fetcher, polling strategy and manager #284

merged 11 commits into from
Dec 13, 2016

Commits on Dec 13, 2016

  1. Extracted queue polling strategy 

    In order to be able to customize the order and manner in which Shoryuken
polls SQS queues, the previous hard-coded strategy was extracted into a
separate class.

This meant that some of the method names were altered to be more generic
(for example rebalance_queue_weight! became messages_received),
otherwise this was a direct extraction.
    @gshutler @mariokostelac
    gshutler authored and mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    d5a38fa View commit details
    Browse the repository at this point in the history

  2. Fixed warnings from houndci

    @gshutler @mariokostelac
    gshutler authored and mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    1fd45b0 View commit details
    Browse the repository at this point in the history

  3. RSpec 3.3.0 alterations 

    Mock "receive" calls appear to use a stronger interpretation of
equality.

Also altered assertions around raised errors to suppress new warnings.
    @gshutler @mariokostelac
    gshutler authored and mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    314038d View commit details
    Browse the repository at this point in the history

  4. Move queue pausing responsibility to PollingStrategy

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    ef73e17 View commit details
    Browse the repository at this point in the history

  5. Make Fetcher superslim

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    308dc5b View commit details
    Browse the repository at this point in the history

  6. Replace unnecessary async calls with synchronous versions

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    2cc523f View commit details
    Browse the repository at this point in the history

  7. Add dispatch tests for manager

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    11988ec View commit details
    Browse the repository at this point in the history

  8. Fix style errors

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    2003039 View commit details
    Browse the repository at this point in the history

  9. Call dispatch after processor is done/dead

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    c582f89 View commit details
    Browse the repository at this point in the history

  10. Use dispatch_later instead of after(1) { dispatch }

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    37062ab View commit details
    Browse the repository at this point in the history

  11. Fix log message

    @mariokostelac
    mariokostelac committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    7fc8393 View commit details
    Browse the repository at this point in the history