Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'forwardable' require in Shoryuken v3.1.3 #408

Closed
rbroemeling opened this issue Jul 14, 2017 · 6 comments
Closed

Missing 'forwardable' require in Shoryuken v3.1.3 #408

rbroemeling opened this issue Jul 14, 2017 · 6 comments

Comments

@rbroemeling
Copy link

On a clean install of Shoryuken v3.1.3, Shoryuken stacktraces like this:

[15:25:18][me@host:~/]$ /usr/local/bin/shoryuken
/usr/local/stow/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/shoryuken-3.1.3/lib/shoryuken.rb:33:in `<module:Shoryuken>': uninitialized constant Shoryuken::SingleForwardable (NameError)
	from /usr/local/stow/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/shoryuken-3.1.3/lib/shoryuken.rb:32:in `<top (required)>'
	from /usr/local/stow/ruby-2.3.3/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/stow/ruby-2.3.3/lib/ruby/site_ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/stow/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/shoryuken-3.1.3/lib/shoryuken/runner.rb:7:in `<top (required)>'
	from /usr/local/stow/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/shoryuken-3.1.3/bin/shoryuken:9:in `require_relative'
	from /usr/local/stow/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/shoryuken-3.1.3/bin/shoryuken:9:in `<top (required)>'
	from /usr/local/bin/shoryuken:22:in `load'
	from /usr/local/bin/shoryuken:22:in `<main>'

This is because 'forwardable' is not required in the Shoryuken source.

Adding require 'forwardable' to lib/shoryuken.rb fixes the problem, after which Shoryuken launches properly:

[15:26:48][me@host:~/]$ /usr/local/bin/shoryuken
2017-07-14T15:26:50Z 29349 TID-otghwlhwc WARN: No queues supplied
2017-07-14T15:26:50Z 29349 TID-otghwlhwc INFO: Starting
^C2017-07-14T15:26:52Z 29349 TID-otghwlhwc INFO: Received INT, will shutdown down
2017-07-14T15:26:52Z 29349 TID-otghwlhwc INFO: Shutting down

This issue manifests under ruby v2.3.3p222/rubygems v2.6.6.

@rbroemeling rbroemeling changed the title Missing 'forwardable' require Missing 'forwardable' require in Shoryuken v3.1.3 Jul 14, 2017
@phstc
Copy link
Collaborator

phstc commented Jul 14, 2017

Hi @rbroemeling

Could you try bundle exec /usr/local/bin/shoryuken?

@rbroemeling
Copy link
Author

@phstc The gem is installed on the system for this particular use case, it isn't bundled.

@phstc
Copy link
Collaborator

phstc commented Jul 14, 2017

@rbroemeling you are right! I'm just waiting for C before merging #409. Thanks for reporting this 🍻

@rbroemeling
Copy link
Author

@phstc Sure thing, thanks for the quick turn-around!

phstc added a commit that referenced this issue Jul 14, 2017
require 'forwardable' to allow using without bundle exec

Fixes #408
@phstc
Copy link
Collaborator

phstc commented Jul 14, 2017

@rbroemeling 3.1.4 is out with your fix 🎉

@rbroemeling
Copy link
Author

@phstc Confirmed that v3.1.4 fixes the problem, thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants