Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Sep 5, 2025

No description provided.

@pboling pboling self-assigned this Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.27%. Comparing base (b0ccb12) to head (a0bf3a2).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   78.75%   84.27%   +5.51%     
==========================================
  Files          40       36       -4     
  Lines        1158     1062      -96     
  Branches        0      298     +298     
==========================================
- Hits          912      895      -17     
+ Misses        246      167      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Sep 5, 2025

Pull Request Test Coverage Report for Build 17680300860

Details

  • 63 of 81 (77.78%) changed or added relevant lines in 16 files are covered.
  • 54 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+1.9%) to 78.632%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/oauth/request_proxy/base.rb 9 10 90.0%
lib/oauth/signature/rsa/sha1.rb 5 6 83.33%
lib/oauth/request_proxy/em_http_request.rb 0 2 0.0%
lib/oauth/request_proxy/rest_client_request.rb 1 3 33.33%
lib/oauth/client/net_http.rb 14 17 82.35%
lib/oauth/consumer.rb 16 25 64.0%
Files with Coverage Reduction New Missed Lines %
lib/oauth/client/helper.rb 1 91.53%
lib/oauth/signature/plaintext.rb 1 92.31%
lib/oauth/request_proxy/base.rb 2 75.93%
lib/oauth/request_proxy/typhoeus_request.rb 2 80.0%
lib/oauth/request_proxy/rest_client_request.rb 5 63.04%
lib/oauth/client/net_http.rb 8 72.73%
lib/oauth/consumer.rb 17 65.84%
lib/oauth/request_proxy/em_http_request.rb 18 34.78%
Totals Coverage Status
Change from base Build 17133331763: 1.9%
Covered Lines: 779
Relevant Lines: 919

💛 - Coveralls

@pboling pboling force-pushed the kettle-dev branch 5 times, most recently from 54855f2 to 94dcab5 Compare September 10, 2025 08:32
@pboling pboling force-pushed the kettle-dev branch 5 times, most recently from cfcd4a9 to ccc26af Compare September 12, 2025 11:25
pboling and others added 10 commits September 12, 2025 23:24
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: |7eter l-|. l3oling <[email protected]>
# Conflicts:
#	.github/workflows/discord-notifier.yml
#	.rubocop_gradual.lock
#	Appraisal.root.gemfile
#	gemfiles/audit.gemfile
#	gemfiles/coverage.gemfile
#	gemfiles/current.gemfile
#	gemfiles/head.gemfile
#	gemfiles/ruby_2_7.gemfile
#	gemfiles/ruby_3_0.gemfile
#	gemfiles/ruby_3_1.gemfile
#	gemfiles/ruby_3_2.gemfile
#	gemfiles/ruby_3_3.gemfile
#	gemfiles/style.gemfile
#	gemfiles/unlocked_deps.gemfile
#	spec/oauth/tty/cli_spec.rb
- lazy Loaded so it can be optional, since some systems fail to install it, and it doesn't seem maintained
- Stop relying on URI / CGI for escaping and unescaping
  - They are both unstable across supported versions of Ruby (including 3.5 HEAD)
- Tests against Rails-specific code are now run in CI
…ty Config

- also discord-notifier.yml, as it is unused for now
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
oauth 84% 54%
Summary 84% (836 / 1000) 54% (150 / 277)

Minimum allowed line rate is 81%

@pboling pboling merged commit e035ccf into main Sep 13, 2025
29 checks passed
@pboling pboling deleted the kettle-dev branch September 13, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants