-
-
Notifications
You must be signed in to change notification settings - Fork 266
➕ kettle-dev #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
➕ kettle-dev #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 78.75% 84.27% +5.51%
==========================================
Files 40 36 -4
Lines 1158 1062 -96
Branches 0 298 +298
==========================================
- Hits 912 895 -17
+ Misses 246 167 -79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17680300860Details
💛 - Coveralls |
54855f2 to
94dcab5
Compare
cfcd4a9 to
ccc26af
Compare
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: |7eter l-|. l3oling <[email protected]>
# Conflicts: # .github/workflows/discord-notifier.yml # .rubocop_gradual.lock # Appraisal.root.gemfile # gemfiles/audit.gemfile # gemfiles/coverage.gemfile # gemfiles/current.gemfile # gemfiles/head.gemfile # gemfiles/ruby_2_7.gemfile # gemfiles/ruby_3_0.gemfile # gemfiles/ruby_3_1.gemfile # gemfiles/ruby_3_2.gemfile # gemfiles/ruby_3_3.gemfile # gemfiles/style.gemfile # gemfiles/unlocked_deps.gemfile # spec/oauth/tty/cli_spec.rb
- make them evergreen
- lazy Loaded so it can be optional, since some systems fail to install it, and it doesn't seem maintained
- Stop relying on URI / CGI for escaping and unescaping - They are both unstable across supported versions of Ruby (including 3.5 HEAD) - Tests against Rails-specific code are now run in CI
…ty Config - also discord-notifier.yml, as it is unused for now
- in support of vcr: vcr/vcr#1057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.