Bug: Update i18n.gemspec to drop support for Ruby 2.x #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.14.3 dropped support for Ruby 2.x but did not bump the gemspec, which would allow 2.x clients to request the new version, but fail to install.
|
I am not sure I want to make this change right at this moment, as I'm sensitive to people potentially still running 2.7. Perhaps next year. |
|
To further clarify: https://endoflife.date/ruby lists Ruby 3.0 support as ended 4 months ago. So should this library support only 3.1 and up? But then it also says that in 6 months Ruby 3.1 support runs out. So then should this be 3.2 and up? I think yes, but only after 2025-03-31. So I will make this change then. I would rather make one change at one date, and provide advance notice of this. Perhaps a post-install message would make this clearer to the wider group of users, starting roughly today and cleaned out when the restriction is tightened in April next yeear. |
radar
added a commit
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.14.3 dropped support for Ruby 2.x but did not bump the gemspec, which would allow 2.x clients to request the new version, but fail to install without recompiling.