Only deep_symbolize_keys when needed #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paarthmadan
force-pushed
the
pm/only-deep-symbolize-keys-when-needed
branch
from
d7dd3dc
to
a85f2ba
Compare
|
I looked at that failing spec but it seems to be a flaky one, nothing caused by your changes here. changes LGTM, will probably merge tomorrow morning or Tuesday, depending on my schedules |
JSON.load_file being defined implies that symbolize_names and freeze options are supported at parse time. We use this as a best effort feature test.
When loading certain translations from file, they can be parsed into their Symbol representation. It is wasteful to traverse the entire object graph in these cases.
paarthmadan
force-pushed
the
pm/only-deep-symbolize-keys-when-needed
branch
from
a85f2ba
to
cbca32e
Compare
|
Apologies for the delay here, it’s been a busy time at work. I will endeavour to look at these issues later this morning.
…On 22 Jan 2022, 05:08 +1100, Paarth Madan ***@***.***>, wrote:
@radar Could this PR, along with #583 and #587 be reconsidered? I've addressed all of your feedback.Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the tentative changes proposed in #587 and #583, we should avoid performing
deep_symbolize_keyson the translations when it's unnecessary.This PR currently includes changes from #587 to showcase usage. I'll update it with changes from #583 too, if and when that merges.
This PR returns an additional attribute from the
load_*methods to provide a flag of whether the keys have been symbolized at parse time. If so, we skipdeep_symbolize_keys. This is a performance optimization that helps avoid traversing the object graph when we don't need to.I suppose we can also inject a magic key in the locale hash indicating whether keys are symbolized already, but I felt this approach was less intrusive.