Fix deprecate_constant INTERPOLATION_PATTERN

[biinari]

deprecate_constant I18n::INTERPOLATION_PATTERN if Module responds to :deprecate_constant

Change introduced in #439 looks like it deprecates this constant, but the original condition will always evaluate as false.

[radar]

I think we could call deprecate_constant without worrying about whether or not it's supported, right? Because Ruby 2.3 and above has deprecate_constant. I'll merge this and double check.

Thank you for submitting this fix!

[biinari]

That's a good point @radar, it does seem to be present from Ruby 2.3 onward. I just happened across this on a wide grep across the gems we're using as it stuck out as being different to other uses of deprecate_constant. Feel free to remove the check entirely as Ruby >= 2.3 is required anyway.

[radar]

Already done in c2d85c0 :)

…

On 24 Jun 2020, 11:18 AM +1000, Bill Ruddock ***@***.***>, wrote: That's a good point @radar, it does seem to be present from Ruby 2.3 onward. I just happened across this on a wide grep across the gems we're using as it stuck out as being different to other uses of deprecate_constant. Feel free to remove the check entirely as Ruby >= 2.3 is required anyway. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.