Merge pull request #12421 from koic/make_style_self_assignment_aware_…

…of_some_operators Make `Style/SelfAssignment` aware of some operators
rubocop · Nov 29, 2023 · 4753e92 · 4753e92
2 parents a31a37c + 2f9a2d2
commit 4753e92
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/changelog/change_make_style_self_assignment_aware_of_some_operators.md b/changelog/change_make_style_self_assignment_aware_of_some_operators.md
@@ -0,0 +1 @@
+* [#12421](https://github.com/rubocop/rubocop/pull/12421): Make `Style/SelfAssignment` aware of `%`, `^`, `<<`, and `>>` operators. ([@koic][])
diff --git a/lib/rubocop/cop/style/self_assignment.rb b/lib/rubocop/cop/style/self_assignment.rb
@@ -16,7 +16,7 @@ class SelfAssignment < Base
         extend AutoCorrector
 
         MSG = 'Use self-assignment shorthand `%<method>s=`.'
-        OPS = %i[+ - * ** / | &].freeze
+        OPS = %i[+ - * ** / % ^ << >> | &].freeze
 
         def self.autocorrect_incompatible_with
           [Layout::SpaceAroundOperators]

diff --git a/spec/rubocop/cop/style/self_assignment_spec.rb b/spec/rubocop/cop/style/self_assignment_spec.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::Cop::Style::SelfAssignment, :config do
-  %i[+ - * ** / | & || &&].product(['x', '@x', '@@x']).each do |op, var|
+  %i[+ - * ** / % ^ << >> | & || &&].product(['x', '@x', '@@x']).each do |op, var|
     it "registers an offense for non-shorthand assignment #{op} and #{var}" do
       expect_offense(<<~RUBY, op: op, var: var)
         %{var} = %{var} %{op} y
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#12421](https://github.com/rubocop/rubocop/pull/12421): Make `Style/SelfAssignment` aware of `%`, `^`, `<<`, and `>>` operators. ([@koic][])