Fix an error for Style/RedundantFormat

Follow-up to #13844 (comment). This PR fixes an error for `Style/RedundantFormat` when numeric placeholders is used in the template argument.
rubocop · Feb 17, 2025 · 241fe6b · 241fe6b
1 parent b573711
commit 241fe6b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_an_error_for_style_redundant_format_cop.md b/changelog/fix_an_error_for_style_redundant_format_cop.md
@@ -0,0 +1 @@
+* [#13857](https://github.com/rubocop/rubocop/pull/13857): Fix an error for `Style/RedundantFormat` when numeric placeholders is used in the template argument. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_format.rb b/lib/rubocop/cop/style/redundant_format.rb
@@ -160,7 +160,7 @@ def matching_argument?(sequence, argument)
         end
 
         def numeric?(argument)
-          argument.type?(:numeric, :str) ||
+          argument&.type?(:numeric, :str) ||
             rational_number?(argument) ||
             complex_number?(argument)
         end

diff --git a/spec/rubocop/cop/style/redundant_format_spec.rb b/spec/rubocop/cop/style/redundant_format_spec.rb
@@ -314,6 +314,12 @@
               #{method}('%{foo}', foo)
             RUBY
           end
+
+          it 'does not register an offense when given numeric placeholders in the template argument' do
+            expect_no_offenses(<<~RUBY)
+              #{method}('%<placeholder>d, %<placeholder>f', placeholder)
+            RUBY
+          end
         end
 
         context 'with an interpolated format string' do
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#13857](https://github.com/rubocop/rubocop/pull/13857): Fix an error for `Style/RedundantFormat` when numeric placeholders is used in the template argument. ([@koic][])