Skip to content

Conversation

@bquorning
Copy link
Collaborator

@bquorning bquorning commented Jul 3, 2020

Two questions (as always):

  • Do we need more PRs merged before releasing?
  • Do we need any VersionChanged/VersionAdded metadata?

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from Darhazer and pirj and removed request for Darhazer July 3, 2020 07:49
@pirj pirj merged commit e6857d8 into master Jul 3, 2020
@pirj pirj deleted the release branch July 3, 2020 09:21
@Darhazer
Copy link
Member

Darhazer commented Jul 3, 2020

Do we need more PRs merged before releasing?

Nope

Do we need any VersionChanged/VersionAdded metadata?

As far as I can see, the changes do not affect the rubocop.yml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants