Skip to content

Allow #traits_for_enum to be used in a FactoryBot factory without a block #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pirj merged 4 commits into from
Jun 29, 2020
Merged

Allow #traits_for_enum to be used in a FactoryBot factory without a block #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad4b1c
Include #traits_for_enum in allowed attribute defining methods
harrylewis Jun 27, 2020
4a5b8ce
Turn horizontal list vertical
harrylewis Jun 27, 2020
e2a8382
Add CHANGELOG entry
harrylewis Jun 29, 2020
4d2278a
Add link to contributor section
harrylewis Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Master (Unreleased)

* Extend the list of Rails spec types for `RSpec/DescribeClass`. ([@pirj][])
* Fix `FactoryBot/AttributeDefinedStatically` to allow `#traits_for_enum` without a block. ([@harrylewis][])

## 1.40.0 (2020-06-11)

Expand Down Expand Up @@ -520,3 +521,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
[@robotdana]: https://github.com/robotdana
[@rolfschmidt]: https://github.com/rolfschmidt
[@andrykonchin]: https://github.com/andrykonchin
[@harrylewis]: https://github.com/harrylewis
8 changes: 7 additions & 1 deletion lib/rubocop/rspec/factory_bot.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ module RuboCop
module RSpec
# RuboCop FactoryBot project namespace
module FactoryBot
ATTRIBUTE_DEFINING_METHODS = %i[factory trait transient ignore].freeze
ATTRIBUTE_DEFINING_METHODS = %i[
factory
ignore
trait
traits_for_enum
transient
].freeze
Comment on lines -7 to +13
Copy link
Contributor Author

@harrylewis harrylewis Jun 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding :traits_for_enum caused a Layout/LineLength offense, so I turned the horizontal list into a vertical list. I also alphabetized the list to align with what was done with the other constants below.


UNPROXIED_METHODS = %i[
__send__
Expand Down
10 changes: 10 additions & 0 deletions spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,16 @@
RUBY
end

it 'accepts valid traits_for_enum definition' do
expect_no_offenses(<<-RUBY)
FactoryBot.define do
factory :post do
traits_for_enum :status, [:draft, :published]
end
end
RUBY
end

bad = <<-RUBY
FactoryBot.define do
factory :post do
Expand Down