Remove redundant files from gem distribution #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to tell why spec files were shipped with a gem, but that doesn't seem to be necessary. Shipping of Gemfile (that is intended to be used for local development), and especially gemspec file is unnecessary as well. Rakefile is not useful except for local RuboCop-RSpec development. There doesn't seem to be any mention of `test_files` option in gem specification reference (https://guides.rubygems.org/specification-reference/#extra_rdoc_files), most probably it's a legacy option.
bquorning
reviewed
Aug 18, 2019
| ] | ||
| spec.test_files = spec.files.grep(%r{^spec/}) |
There was a problem hiding this comment.
I’m not sure what it should be used for 🤷♂
There was a problem hiding this comment.
And also this back from 2014 rubygems/guides#90 (comment)
In relation to why the setting of this option still works is:
Starting in RubyGems 2.0, a Specification can hold arbitrary metadata.
bquorning
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to tell why spec files were shipped with a gem, but that doesn't seem to be necessary.
Shipping of Gemfile (that is intended to be used for local development), and especially gemspec file is unnecessary as well.
Rakefile is not useful except for local RuboCop-RSpec development.
There doesn't seem to be any mention of
test_filesoption in gem specification reference,most probably it's a legacy option.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).