Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Remove duplicated examples #2011

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[DOC] Remove duplicated examples #2011

merged 1 commit into from
Dec 23, 2024

Conversation

kyanagi
Copy link
Contributor

@kyanagi kyanagi commented Dec 23, 2024

These two examples appear twice.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • Added the new cop to config/default.yml.
  • The cop is configured as Enabled: pending in config/default.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop documents examples of good and bad code.
  • The tests assert both that bad code is reported and that good code is not reported.
  • Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@kyanagi kyanagi requested a review from a team as a code owner December 23, 2024 07:56
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah
Copy link
Member

ydah commented Dec 23, 2024

Prism failures are not relevant to this PR and will be merged.
https://github.com/rubocop/rubocop-rspec/actions/runs/12463339263/job/34786098205?pr=2011

@ydah ydah merged commit 483d00b into rubocop:master Dec 23, 2024
24 of 25 checks passed
@kyanagi kyanagi deleted the patch-1 branch December 24, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants