Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.3.0 #2007

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Release v3.3.0 #2007

merged 2 commits into from
Dec 12, 2024

Conversation

bquorning
Copy link
Collaborator

It’s 9 weeks since last release. We have a bugfix and a deprecation waiting to go out.

I tried to fix the publish.yml workflow, hoping that the workflows will be triggered on the PR created after publishing the gem. Let’s see.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

The last step in this workflow's publish run opens a PR, but the actions
are not running on the PR, requiring a manual triggering or force-push.
It will save us time if this way, we can merge the created PR sooner.
@bquorning bquorning changed the title Release Release v3.3.0 Dec 12, 2024
@bquorning bquorning marked this pull request as ready for review December 12, 2024 12:19
@bquorning bquorning requested a review from a team as a code owner December 12, 2024 12:19
@bquorning
Copy link
Collaborator Author

cc @pirj, @ydah

@bquorning bquorning merged commit 4272587 into master Dec 12, 2024
24 of 25 checks passed
@bquorning bquorning deleted the release branch December 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants