Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSpec 4 CI to the monorepo #2006

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

Earlopain
Copy link
Contributor

Also see rubocop/rubocop#13576


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@Earlopain Earlopain requested a review from a team as a code owner December 12, 2024 12:02
@pirj
Copy link
Member

pirj commented Dec 12, 2024

Thank you!

Please let me do a quick sanity check, since it's not obvious at all from the CI job which RSpec version was installed apart from

Removing rspec (3.13.0)

which is not indicative.

I intend to:

  1. Remove some clamp around old-fashioned code that makes RSpec 4 to break
  2. Observe the RSpec 4 CI job to fail
  3. Revert the commit
    ...
  4. Merge!

@Earlopain
Copy link
Contributor Author

Yeah, sure 👍. I observed the lockfile locally and it did seem to grab the correct version.

@pirj
Copy link
Member

pirj commented Dec 12, 2024

Failed as expected:

undefined method `it_should_behave_like' for class RSpec::ExampleGroups::Weirdness

My apologies for being extra cautious, and thanks once again!

@pirj
Copy link
Member

pirj commented Dec 12, 2024

@bquorning Can you merge without Mdformat passing? I recall there was a checkbox to merge anyway, but most probably in rspec-factory_bot.

@ydah Do you have an idea what README.md does it complain about?

@bquorning
Copy link
Collaborator

Yep, I’ll force-merge this one. We will fix mdformat in another PR.

@bquorning bquorning merged commit f659b41 into rubocop:master Dec 12, 2024
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants