-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoCorrect: contextual
needs rubocop v1.61
#1901
Conversation
The is is a big jump How did you catch this? |
This makes me a bit hesitant to backport our contextual autocorrection to 2-x-stable. |
That would be https://github.com/rubocop/rubocop-rspec/actions/runs/9355023880/job/25749240673, using |
The failing CI is because rubocop/rubocop-rspec_rails#30 is not (and cannot be) merged yet. |
I’m trying to read rubocop/rubocop#12657 and I think if people are using an older version of RuboCop than v1.61, autocorrect will just keep working as it always has. But if they’re using v1.61+ then they get the new LSP feature too. In conclusion, I don’t think we need this PR. People who want to use LSP should use RuboCop v1.61+ anyway. But on the other hand, the target branch is |
@bquorning Thanks for catching that. You're right, it is indeed. I'm going to close this PR since there is no need to necessarily update version it. |
Yeah, maybe we should have merged this before v3.0.0. |
Let's do that. @pirj WDYT? |
I added one commit, so that merging this PR will release v3.0.1. I feel like I have been a little too eager to merge and release lately, so I’ll wait for @pirj to review before merging. |
Let’s merge and release as 3.0.1, i see no big harm here. The only problem would be people doing I’d be most interested in why our CI “oldest rubocop” job didn’t catch this. |
In the following sections, if AutoCorrect was set to a value other than boolean, the corresponding error message was output, so it was necessary to update to v1.61. So, let's change it and release it. |
https://github.com/rubocop/rubocop/releases/tag/v1.61.0
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).