Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus
#1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Sep 21, 2023
ydah
force-pushed
the
fix-incorrect-autocorrect-httpstatus
branch
from
470af75 to
6deb770
Compare
ydah
changed the title
RSpec/Rails/HttpStatus when single quoted string valueRSpec/Rails/HttpStatus
ydah
force-pushed
the
fix-incorrect-autocorrect-httpstatus
branch
from
6deb770 to
488ab00
Compare
bquorning
approved these changes
Sep 23, 2023
ydah
force-pushed
the
fix-incorrect-autocorrect-httpstatus
branch
from
488ab00 to
61213e4
Compare
…RSpec/Rails/HttpStatus`
reproduction code
```rb
it { is_expected.to have_http_status '200' }
it { is_expected.to have_http_status "%[200]" }
it { is_expected.to have_http_status <<~HTTP }
200
HTTP
```
expected
```rb
it { is_expected.to have_http_status :ok }
it { is_expected.to have_http_status :ok }
it { is_expected.to have_http_status <<~HTTP } # not offense
200
HTTP
```
actual
```rb
it { is_expected.to have_http_status }
it { is_expected.to have_http_status }
it { is_expected.to have_http_status }
200
HTTP
```
ydah
force-pushed
the
fix-incorrect-autocorrect-httpstatus
branch
from
61213e4 to
5394ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support single quoted string and percent string and heredoc for
RSpec/Rails/HttpStatus.reproduction code
expected
actual