Make hook scopes and runners non-configurable #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
make-runners-and-hook-scopes-non-configurable
branch
from
0cc339e to
b50fa4d
Compare
As opposed to other RSpec DSL elements, there is no obvious way of configuring aliases for them. It doesn't make sense to expose them in the configuration file, as those won't ever be configured by users.
pirj
force-pushed
the
make-runners-and-hook-scopes-non-configurable
branch
from
b50fa4d to
744918d
Compare
bquorning
approved these changes
Nov 3, 2022
Darhazer
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other RSpec DSL elements, there is no obvious way of configuring aliases for runners, and there's no point (I know of) and no straightforward way for adding more hook scopes.
It doesn't make sense to expose them in the configuration file, as those won't ever be configured by users.
Originated from
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).