Fix .rubocop_todo.yml #1263
Merged
Fix .rubocop_todo.yml #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
commented
Apr 20, 2022
| Max: 106 | ||
|
|
||
| RSpec/ExampleLength: | ||
| Exclude: |
There was a problem hiding this comment.
Doesn't seem to cause any trouble anymore
| @@ -129,17 +128,13 @@ def message(offense) | |||
| end | |||
|
|
|||
| def scope_change?(node) | |||
| scope_changing_syntax?(node) || | |||
| @@ -152,6 +147,7 @@ def offensive?(node) | |||
|
|
|||
| def offensive_described_class?(node) | |||
| return unless node.const_type? | |||
|
|
|||
There was a problem hiding this comment.
Styling. I found it hard to understand what guard statement this comment relates to.
| # rubocop:disable InternalAffairs/NodeDestructuring | ||
| namespace, name = *node | ||
| # rubocop:enable InternalAffairs/NodeDestructuring | ||
| namespace, name = *node # rubocop:disable InternalAffairs/NodeDestructuring |
bquorning
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
I had completely forgotten about #982. I still think it makes sense to extract the logic instead of just “inline methods and remove line breaks” as this PR seems to do. Or to follow @Darhazer’s advice and look towards rubocop-ast (and perhaps move some logic from our repository to their repository).
Darhazer
approved these changes
Apr 21, 2022
Makes total sense. Especially since the cop is on alerting 100% usage of allowed lines. I can handle this refactoring separately in #982. |
pirj
force-pushed
the
fix-metrics-classlength-2
branch
from
4cdd2b2 to
648e5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a shortcut compared to #982
My apologies it took me nearly two years 😄
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).