Cop idea: detect repeated describe/context description

[lazycoder9]

In the company, we had a situation when someone pushed specs with duplicated context occasionally and only PR reviewers caught it.

context "when cool thing happens" do
    # some examples
end

context "when cool thing happens" do
    # some examples
end

We tried to find some cops in rubocop-rspec which will detect this kind of occasion, but there were only RSpec/RepeatedExample and RSpec/RepeatedDescription and these cops do not detect repeated descriptions in describe/context, only examples.
So my question is, does it worth to implement different cops for describe/context like above ones or we can extend them to cover these cases?

[pirj]

It does make sense to add a new cop. Should be pretty straightforward, since RepeatedDescription is very similar code-wise.

[lazycoder9]

@pirj Hey, thanks for reply. Actually, several days ago I've already created PR I'm our company's rubocop repository with new 4 cops. And yes, I took main ideas from RSpec/RepeatedDescription implementation, but code is still very raw - there is not enough test cases in cops' specs. So, if you agree, I can move this PR here and firstly create PR only with describe nodes and enhance implementation. What do you think?

[pirj]

Perfect!
I'm thinking that RepeatedDescribeBody and RepeatedContextDescription could be merged into one with a couple changes:

- (begin (block (send nil? :context ...) ...)+ )
+ (begin (block (send nil? {:context :describe} ...) ...)+ )

There are actually more example group types (example_group/feature/...) all conveniently pre-defined here so it's possible to use:

def_node_matcher :example_group?, ExampleGroups::ALL.block_pattern

(begin (block (send nil? #example_group? ...) ...)+ )

Also, group them by example group type:

- .group_by { |child| [extract_metadata(child), extract_body(child)] }
+ .group_by { |child| [child.method_name, extract_metadata(child), extract_body(child)] }