Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cop idea: the correct use of it and specify blocks. #1658

Closed
ydakuka opened this issue Jun 7, 2023 · 1 comment · Fixed by #1666
Closed

Cop idea: the correct use of it and specify blocks. #1658

ydakuka opened this issue Jun 7, 2023 · 1 comment · Fixed by #1666
Labels
cop good first issue

Comments

@ydakuka
Copy link

ydakuka commented Jun 7, 2023

StyleGuide: https://rspec.rubystyle.guide/#it-and-specify
@ydakuka ydakuka changed the title New cop: the correct use of it and specify blocks. Cop idea: the correct use of it and specify blocks. Jun 7, 2023
@Drenmi
Copy link
Contributor

Drenmi commented Jun 10, 2023

Use specify if the example doesn’t have a description.

This one seems pretty straight-forward. Ignore for single line blocks and assertions starting with is_expected.

ydah added a commit that referenced this issue Jun 18, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
9cadd3c 
Fix: #1658
@ydah ydah mentioned this issue Jun 18, 2023
Merged
12 tasks
ydah added a commit that referenced this issue Jun 18, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
b9f1aa3 
Fix: #1658
ydah added a commit that referenced this issue Jul 7, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
a4f518f 
Fix: #1658
ydah added a commit that referenced this issue Jul 9, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
1c35c4b 
Fix: #1658
ydah added a commit that referenced this issue Jul 9, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
f83d0da 
Fix: #1658
ydah added a commit that referenced this issue Jul 20, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
1218d56 
Fix: #1658
ydah added a commit that referenced this issue Jul 24, 2023
@ydah
Add new RSpec/ProperlyItSpecify cop
2ed3258 
Fix: #1658
@ydakuka ydakuka mentioned this issue Oct 17, 2023
Open
ydah added a commit that referenced this issue Feb 15, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
3be3682 
Fix: #1658
ydah added a commit that referenced this issue Feb 15, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
5aad8fb 
Fix: #1658
ydah added a commit that referenced this issue Feb 15, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
2e916cb 
Fix: #1658
ydah added a commit that referenced this issue Feb 17, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
27d44d3 
Fix: #1658
ydah added a commit that referenced this issue Feb 27, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
be1aeb3 
Fix: #1658
ydah added a commit that referenced this issue Feb 27, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
18cbdfb 
Fix: #1658
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
42a8d30 
Fix: rubocop/rubocop-rspec#1658
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this issue Mar 27, 2024
@ydah
Add new RSpec/IsExpectedSpecify cop
28de064 
Fix: rubocop/rubocop-rspec#1658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cop good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new RSpec/IsExpectedSpecify cop rubocop/rubocop-rspec
3 participants
@Drenmi @ydakuka @ydah