Skip to content

Suppress RuboCop's offense#355

Merged
koic merged 1 commit intorubocop:masterfrom
koic:suppress_rubocop_offense
Sep 13, 2020
Merged

Suppress RuboCop's offense#355
koic merged 1 commit intorubocop:masterfrom
koic:suppress_rubocop_offense

Conversation

@koic
Copy link
Copy Markdown
Member

@koic koic commented Sep 13, 2020

Follow rubocop/rubocop#8707

This PR suppresses the following RuboCop's offense.

% bundle exec rake
(snip)

Offenses:

spec/rubocop/cop/active_record_helper_spec.rb:6:3: W:
Lint/ConstantDefinitionInBlock: Do not define constants within a block.
  module RuboCop ...
    ^^^^^^^^^^^^^^

185 files inspected, 1 offense detected, 1 offense auto-correctable
RuboCop failed!

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow rubocop/rubocop#8707

This PR suppresses the following RuboCop's offense.

```console
% bundle exec rake
(snip)

Offenses:

spec/rubocop/cop/active_record_helper_spec.rb:6:3: W:
Lint/ConstantDefinitionInBlock: Do not define constants within a block.
  module RuboCop ...
    ^^^^^^^^^^^^^^

185 files inspected, 1 offense detected, 1 offense auto-correctable
RuboCop failed!
```
@koic koic merged commit 13a0fbe into rubocop:master Sep 13, 2020
@koic koic deleted the suppress_rubocop_offense branch September 13, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant