Add new Performance/ConstantRegexp cop#174
Merged
marcandre merged 1 commit intorubocop:masterfrom Oct 26, 2020
Merged
Conversation
marcandre
reviewed
Sep 29, 2020
Contributor
marcandre
left a comment
marcandre
left a comment
There was a problem hiding this comment.
Awesome!
Two nitpicks, and one additional request: could we also flag /...#{Regexp.escape(CONST)}.../?
I can't think of other method calls I would expect to see...
fatkodima
force-pushed
the
constant_regexp
branch
from
13cd593 to
0d5b5fb
Compare
Contributor
Author
|
Updated with suggestions. |
marcandre
reviewed
Sep 29, 2020
Contributor
|
Could you please rebase? We need this :-) |
fatkodima
force-pushed
the
constant_regexp
branch
from
0d5b5fb to
dfc6934
Compare
Contributor
Author
|
Rebased. |
marcandre
reviewed
Oct 26, 2020
fatkodima
force-pushed
the
constant_regexp
branch
from
dfc6934 to
d50ca82
Compare
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
@marcandre, mentioning you as the original requestor :)