Merge pull request #320 from fatkodima/regexp_match-regexp-cbase

Fix `Performance/RegexpMatch` to handle `::Regexp`
rubocop · Dec 1, 2022 · 9d2ac69 · 9d2ac69
2 parents 55f7f4b + 2842d2b
commit 9d2ac69
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/changelog/fix_regexp_match_to_handle_cbase_regexp.md b/changelog/fix_regexp_match_to_handle_cbase_regexp.md
@@ -0,0 +1 @@
+* [#314](https://github.com/rubocop/rubocop-performance/issues/314): Fix `Performance/RegexpMatch` to handle `::Regexp`. ([@fatkodima][])
diff --git a/lib/rubocop/cop/performance/regexp_match.rb b/lib/rubocop/cop/performance/regexp_match.rb
@@ -124,8 +124,8 @@ def match_with_lvasgn?(node)
 
         def_node_search :last_matches, <<~PATTERN
           {
-            (send (const nil? :Regexp) :last_match)
-            (send (const nil? :Regexp) :last_match _)
+            (send (const {nil? cbase} :Regexp) :last_match)
+            (send (const {nil? cbase} :Regexp) :last_match _)
             ({back_ref nth_ref} _)
             (gvar #match_gvar?)
           }

diff --git a/spec/rubocop/cop/performance/regexp_match_spec.rb b/spec/rubocop/cop/performance/regexp_match_spec.rb
@@ -98,7 +98,7 @@ def foo
     %w[
       $& $' $` $~ $1 $2 $100
       $MATCH
-      Regexp.last_match Regexp.last_match(1)
+      Regexp.last_match ::Regexp.last_match Regexp.last_match(1)
     ].each do |var|
       it "accepts #{name} in method with #{var}" do
         expect_no_offenses(<<~RUBY)