Add new Minitest/AssertPathExists and Minitest/RefutePathExists cops
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
path-exists-cops
branch
from
02d1638
to
a63371c
Compare
|
Rebased. |
bbatsov
reviewed
Jul 2, 2020
bbatsov
reviewed
Jul 2, 2020
fatkodima
force-pushed
the
path-exists-cops
branch
from
a63371c
to
59d8859
Compare
|
Updated links. |
This is an issue with Minitest RuboCop, but this PR is fine as a first step. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/rubocop-hq/minitest-style-guide#assert-path-exists
Both cops are almost identical (same as
AssertNilandRefuteNil, for example). Is it worth extracting (and complicating a bit) somehow into, say, module?