Adds cop to enforce refute_instance_of over refute(object.instance_of?(Class)) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaynikam
force-pushed
the
adds-cop-for-refute-instance-of
branch
from
6e75828
to
02278bc
Compare
|
Can you rebase with latest master? |
abhaynikam
force-pushed
the
adds-cop-for-refute-instance-of
branch
from
02278bc
to
a51afb7
Compare
abhaynikam
force-pushed
the
adds-cop-for-refute-instance-of
branch
from
a51afb7
to
f96af5f
Compare
|
@koic : Rebased PR with latest master. Thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds cops to enforce the use of refute_instance_of over refute(object.instance_of?(Class))
Ref: https://github.com/rubocop-hq/minitest-style-guide#refute-instance-of