-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an error for Minitst/AssertOperator
and Minitest/RefuteOperator
#275
Merged
koic
merged 1 commit into
rubocop:master
from
koic:add_ci_for_the_oldest_supported_rubocop_version
Nov 25, 2023
Merged
Fix an error for Minitst/AssertOperator
and Minitest/RefuteOperator
#275
koic
merged 1 commit into
rubocop:master
from
koic:add_ci_for_the_oldest_supported_rubocop_version
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_ci_for_the_oldest_supported_rubocop_version
branch
6 times, most recently
from
November 23, 2023 08:03
890a633
to
7c9e66e
Compare
koic
changed the title
Add CI for the oldest supported RuboCop version
Fix an error for Nov 23, 2023
Minitst/AssertOperator
and Minitest/RefuteOperator
koic
force-pushed
the
add_ci_for_the_oldest_supported_rubocop_version
branch
2 times, most recently
from
November 24, 2023 04:18
7be26a0
to
c01dbbb
Compare
This PR fixes the following error for `Minitst/AssertOperator` and `Minitest/RefuteOperator` when running with Ruby 2.7: ```console $ ruby -v ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-darwin19] $ bundle exec rake Finished in 2.522134s, 15.0666 runs/s, 18.6350 assertions/s. 1) Error: RefuteOperatorTest#test_registers_offense_when_using_refute_with_operator_method_and_message: FrozenError: can't modify frozen String: "expected, :<, actual" /Users/koic/src/github.com/rubocop/rubocop-minitest/lib/rubocop/cop/minitest/refute_operator.rb:46: in `build_new_arguments' /Users/koic/src/github.com/rubocop/rubocop-minitest/lib/rubocop/cop/minitest/refute_operator.rb:30: in `on_send' ``` And it introduces CI for the oldest RuboCop version still supported, implementing a workflow for regression testing that is similar to the one found a rubocop/rubocop-rails@c9acb7a.
koic
force-pushed
the
add_ci_for_the_oldest_supported_rubocop_version
branch
from
November 24, 2023 04:20
c01dbbb
to
50a352c
Compare
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
8 tasks
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 27, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Nov 28, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Dec 14, 2023
This PR will centralize CI to GitHub Actions as introduced in rubocop#275.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error for
Minitst/AssertOperator
andMinitest/RefuteOperator
when running with Ruby 2.7:
And it introduces CI for the oldest RuboCop version still supported, implementing a workflow for regression testing that is similar to the one found a rubocop/rubocop-rails@c9acb7a.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.