Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore offenses inside redundant parentheses #270

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented Oct 23, 2023

rubocop/rubocop#11739 updated Style/RedundantParentheses to detect this, so we can now consider it out of scope of these cops, as was done in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

rubocop/rubocop#11739 updated `Style/RedundantParentheses` to detect
this, so we can now consider it out of scope of these cops, as was done
in https://github.com/rubocop/rubocop-minitest/pull/248/files#r1150046949.
@koic
Copy link
Member

koic commented Oct 24, 2023

I think this can be incorporated. So I'll merge this proposal.

@koic koic merged commit a8bd8a7 into rubocop:master Oct 24, 2023
10 checks passed
@sambostock sambostock deleted the ignore-redundant-parens branch October 24, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants