Make Minitest/AssertInstanceOf and Minitest/RefuteInstanceOf aware of assert_equal and refute_equal
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_instance_of_cops_aware_of_equal
branch
from
acc47ea
to
840b1c2
Compare
koic
force-pushed
the
make_instance_of_cops_aware_of_equal
branch
from
840b1c2
to
f8202b3
Compare
koic
commented
Mar 28, 2023
| assert_offense(<<~RUBY) | ||
| class FooTest < Minitest::Test | ||
| def test_do_something | ||
| refute((object.instance_of?(SomeClass))) | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `refute_instance_of(SomeClass, object)`. |
There was a problem hiding this comment.
NOTE: Redundant parentheses will be resolved in rubocop/rubocop#11739, so removed from this cop role.
koic
force-pushed
the
make_instance_of_cops_aware_of_equal
branch
3 times, most recently
from
3af2fbd
to
158f2e9
Compare
…e of `assert_equal` and `refute_equal` This PR makes `Minitest/AssertInstanceOf` and `Minitest/RefuteInstanceOf` aware of `assert_equal(Class, object.class)` and `refute_equal(Class, object.class)`.
koic
force-pushed
the
make_instance_of_cops_aware_of_equal
branch
from
158f2e9
to
2d9e7ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Minitest/AssertInstanceOfandMinitest/RefuteInstanceOfaware ofassert_equal(Class, object.class)andrefute_equal(Class, object.class).Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.