Mark Minitest/RefuteFalse as unsafe
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
mark_minitest_refute_false_as_unsafe_autocorrection
branch
from
46f03a4
to
442c0ec
Compare
koic
changed the title
Minitest/RefuteFalse as unsafe autocorrectionMinitest/RefuteFalse as unsafe
Follow up rubocop#209 (comment) This PR marks `Minitest/RefuteFalse` as unsafe.
koic
force-pushed
the
mark_minitest_refute_false_as_unsafe_autocorrection
branch
from
442c0ec
to
5ca83aa
Compare
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Jan 21, 2023
This PR marks `Minitest/AssertTruthy` as unsafe. As with rubocop#233, this is a false positive issue than autocorrection compatibility.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #209 (comment)
This PR marks
Minitest/RefuteFalseas unsafe.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.