Include a Cop to enforce refute_equal over assert(negations) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duduribeiro
commented
Oct 3, 2019
duduribeiro
force-pushed
the
cop_to_enforce_refute_equal
branch
4 times, most recently
from
b9599f9
to
0eebc89
Compare
koic
reviewed
Oct 4, 2019
|
Most of my feedback from your other PR applies here as well. |
duduribeiro
force-pushed
the
cop_to_enforce_refute_equal
branch
3 times, most recently
from
4be949f
to
fc38458
Compare
duduribeiro
force-pushed
the
cop_to_enforce_refute_equal
branch
from
fc38458
to
70f967a
Compare
This commit adds a Cop that checks some usage of `assert(some negations)` and enforces the usage of `refute_eqaul(expected, actual)` instead.
duduribeiro
force-pushed
the
cop_to_enforce_refute_equal
branch
from
70f967a
to
dbbbd10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Cop that checks some usage of
assert(some negations)and enforces the usage ofrefute_eqaul(expected, actual)instead.Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.