Fix an incorrect autocorrect for Minitest/AssertMatch
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an incorrect autocorrect for `Minitest/AssertMatch` when `assert` with `match` and RHS is a regexp literal. A regular expression literal must be the first argument to `assert_match`. `TypeError: no implicit conversion of Regexp into String` will occur if it is passed as the second argument. ```ruby assert_match(object, /regexp/) #=> TypeError: no implicit conversion of Regexp into String ``` This issue was found on faker-ruby/faker#2556.
koic
deleted the
fix_an_incorrect_autocorrect_for_minitest_assert_match
branch
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Sep 27, 2022
Follow up rubocop#181 and rubocop#184. This PR fixes an incorrect autocorrect for `Minitest/AssertMatch` when `refute` with `match` and RHS is a regexp literal. A regular expression literal must be the first argument to `refute_match`. `TypeError: no implicit conversion of Regexp into String` will occur if it is passed as the second argument. ```ruby refute_match(object, /regexp/) #=> TypeError: no implicit conversion of Regexp into String ```
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect autocorrect for
Minitest/AssertMatchwhenassertwithmatchand RHS is a regexp literal.A regular expression literal must be the first argument to
assert_match.TypeError: no implicit conversion of Regexp into Stringwill occur if it is passed as the second argument.This issue was found on faker-ruby/faker#2556.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.