-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cop to prevent regexp literals as arguments to assert_matches #179
Merged
koic
merged 1 commit into
rubocop:master
from
rwstauner:rwstauner/assert-raises-regexp-literal
Sep 3, 2022
Merged
Add cop to prevent regexp literals as arguments to assert_matches #179
koic
merged 1 commit into
rubocop:master
from
rwstauner:rwstauner/assert-raises-regexp-literal
Sep 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
commented
Sep 2, 2022
rwstauner
commented
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
koic
reviewed
Sep 2, 2022
rwstauner
force-pushed
the
rwstauner/assert-raises-regexp-literal
branch
from
September 2, 2022 15:50
794a39c
to
788f4ce
Compare
thanks for the thorough review and all the explanations! |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cop that checks for regular expression literals being passed to
assert_raises
.These will not validate the message for the raised exception but will generate a potentially confusing
TypeError
when the expected exception does not raise.I didn't see docs for updating
config/default.yml
, let me know if I need to change that.Thanks!
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.