Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop-minitest 0.6.1 errors on assert(variable) #55

Closed
herwinw opened this issue Feb 18, 2020 · 2 comments · Fixed by #57
Closed

Rubocop-minitest 0.6.1 errors on assert(variable) #55

herwinw opened this issue Feb 18, 2020 · 2 comments · Fixed by #57
Labels
bug Something isn't working

Comments

@herwinw
Copy link
Contributor

herwinw commented Feb 18, 2020

Minimal reproduction case:

a = true
assert(a)

Expected behavior

Accept this code

Actual behavior

An error occurred while Minitest/AssertIncludes cop was inspecting $filename.
undefined method `method?' for s(:lvar, :a):RuboCop::AST::Node
Did you mean?  method
               methods
.../rubocop-minitest-0.6.1/lib/rubocop/cop/mixin/includes_cop_rule.rb:16:in `on_send'
.......

Steps to reproduce the problem

See above

RuboCop version

$ [bundle exec] rubocop -V
0.80.0 (using Parser 2.7.0.2, running on ruby 2.3.3 i386-linux-gnu)
@rmm5t
Copy link

rmm5t commented Feb 19, 2020

I just experienced the exact same issue after upgrading to v0.6.1

@koic koic added the bug Something isn't working label Feb 19, 2020
@Maimer Maimer mentioned this issue Feb 19, 2020
Closed
koic added a commit to koic/rubocop-minitest that referenced this issue Feb 19, 2020
@koic
[Fix rubocop#55] Fix an error for Minitest/AssertIncludes
00a6d1c 
Fixes rubocop#55

This PR fixes an error for `Minitest/AssertIncludes` when using local
variable argument.
@koic koic mentioned this issue Feb 19, 2020
Merged
8 tasks
@koic koic closed this as completed in #57 Feb 19, 2020
koic added a commit that referenced this issue Feb 19, 2020
@koic
Merge pull request #57 from koic/fix_an_error_for_assert_includes
adcf02e 
[Fix #55] Fix an error for `Minitest/AssertIncludes`
@koic
Copy link
Member

koic commented Feb 19, 2020

RuboCop Minitest 0.6.2 has been released to solve this issue. Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #55] Fix an error for Minitest/AssertIncludes koic/rubocop-minitest
3 participants
@rmm5t @koic @herwinw