Minitest/RefuteEmpty mangles File.empty?

[go2null]

RuboCop::Minitest/RefuteEmpty does not correctly handle File.empty?.

Expected behavior

RuboCop Minitest should not change the statement.

Actual behavior

RubuCop Minitest changes the code to be non-functioning

- refute File.empty?(@path)
+ refute_empty(File, @path)

Steps to reproduce the problem

1. create the following test file

# frozen_string_literal: true

require_relative 'test_helper'

class RubocopMinitestAssertEmpty < Minitest::Test
  def test_that_file_is_not_empty
    refute File.empty?(__FILE__)
  end
end

1. verify that it works

$ bundle exec ruby test/rubocop_minitest_assert_empty_bug.rb
Run options: --seed 20479

# Running:

.

Fabulous run in 0.009087s, 110.0522 runs/s, 110.0522 assertions/s.

1 runs, 1 assertions, 0 failures, 0 errors, 0 skips

2. run RuboCop Minitest

$ rubocop --auto-correct

test/rubocop_minitest_assert_empty_bug.rb:7:5: C: [Corrected] Minitest/RefuteEmpty: Prefer using refute_empty(File, __FILE__) over refute(File.empty?(__FILE__)).
    refute File.empty?(__FILE__)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

3. verify change made

# frozen_string_literal: true

require_relative 'test_helper'

class RubocopMinitestAssertEmpty < Minitest::Test
  def test_that_file_is_not_empty
    refute_empty File, __FILE__
  end
end

4. try running test

$ bundle exec ruby test/rubocop_minitest_assert_empty_bug.rb
Run options: --seed 18518

# Running:

E

Fabulous run in 0.001397s, 715.8196 runs/s, 715.8196 assertions/s.

  1) Error:
RubocopMinitestAssertEmpty#test_that_file_is_not_empty:
ArgumentError: wrong number of arguments (given 0, expected 1)
    test/rubocop_minitest_assert_empty_bug.rb:7:in `test_that_file_is_not_empty'

1 runs, 1 assertions, 0 failures, 1 errors, 0 skips

RuboCop version

$ bundle exec rubocop -V
1.22.1 (using Parser 3.0.2.0, rubocop-ast 1.12.0, running on ruby 2.7.2 x86_64-msys)
  - rubocop-minitest 0.15.2
  - rubocop-rake 0.6.0

[andyw8]

FYI @abhaynikam (#20)