Fix smoke test and add workflow #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
commented
Feb 4, 2023
| @@ -98,6 +98,7 @@ def self.defaults! | |||
| patch "lib/#{dirname}.rb", 'module Rubocop', 'module RuboCop' | |||
| patch "lib/#{dirname}/version.rb", 'module Rubocop', 'module RuboCop' | |||
| patch "#{name}.gemspec", 'Rubocop', 'RuboCop' | |||
| 2.times { patch "spec/#{dirname}_spec.rb", 'Rubocop::', 'RuboCop::' } | |||
There was a problem hiding this comment.
Oh, I guess this is an actual bug fix, not just a smoke test fix. The smoke test found the bug, because it would blow up due to the constant being incorrect. See commit message for details.
|
I don't think the workflow will run on this branch, as it doesn't exist on |
The generated spec looks like
RSpec.describe Rubocop::Smoke do
it "has a version number" do
expect(Rubocop::Smoke::VERSION).not_to be nil
end
Because `patch` uses `sub`, not `gsub`, we must apply the patch twice,
to replace both occurences of `Rubocop` with `RuboCop`.
The generated spec file intentionally has a failing spec in it, so gem authors write specs. If we are to use running specs as a way to check if the generator works, then we need to make that spec pass.
The smoke test was broken. Putting it in a workflow ensures we find out early if it happens again.
sambostock
force-pushed
the
fix-smoke-test
branch
from
9cc584c to
b400944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoke test was broken. This minimally fixes it, and adds a workflow to run it.