Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax "one expectation per example" rule #47

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

pirj
Copy link
Member

@pirj pirj commented Oct 25, 2018

With the introduction of aggregate_failures feature in RSpec 3.3 there are no strong arguments left to stick to the strict style, as the output remains the same, while context initialization costs are reduced.

Initially, this was brought up in #11, this change is partially based on it.

Closes #11

@pirj pirj self-assigned this Oct 25, 2018
@pirj pirj changed the title With the [introduction of aggregate_failures feature in RSpec 3.3](http://rspec.info/blog/2015/06/rspec-3-3-has-been-released/) there are no strong arguments left to stick to the strict style, as the output remains the same, while context initialization costs are reduced. Relax "one expectation per example" rule Oct 25, 2018
@pirj pirj requested a review from Darhazer October 25, 2018 11:32
With the [introduction of `aggregate_failures` feature in RSpec 3.3](http://rspec.info/blog/2015/06/rspec-3-3-has-been-released/)
there are no strong arguments left to stick to the strict style, as the
output remains the same, while context initialization costs are reduced.

Closes #11
@pirj pirj force-pushed the relax-one-expectation-per-example-rule branch from 07e6235 to 92685ab Compare October 25, 2018 12:01
@bbatsov bbatsov merged commit d154ff9 into master Oct 25, 2018
@bbatsov bbatsov deleted the relax-one-expectation-per-example-rule branch October 25, 2018 22:12
@pirj
Copy link
Member Author

pirj commented Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants