Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage stubbing subject #32

Closed
Darhazer opened this issue Aug 11, 2018 · 0 comments
Closed

Discourage stubbing subject #32

Darhazer opened this issue Aug 11, 2018 · 0 comments
Assignees
@pirj

Comments

@Darhazer
Copy link
Member

Some times people stub helper methods in the object they are testing, but that's a test smell and often indicate a bad design on the object itself.

RSpec/SubjectStub cop flags allow and expect on the subject
@pirj pirj added the help wanted Beginner-friendly contribution label Aug 13, 2018
@pirj pirj removed the help wanted Beginner-friendly contribution label Oct 26, 2018
@pirj pirj self-assigned this Oct 26, 2018
pirj added a commit that referenced this issue Oct 26, 2018
@pirj
Discourage stubbing the subject
ed7b1bb 
Resolves #32
@pirj pirj mentioned this issue Oct 26, 2018
Merged
@pirj pirj closed this as completed in 13b7d01 Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirj @Darhazer