GH-182: Allow forcing colored/coloured output #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@msabramo Thanks for the contribution Marc! It would be great if we could have a couple of basic tests for this feature. Would you mind adding them (like testing COLOR=yes and COLOR=no at least)? Otherwise, it looks good for merging! |
Contributor
Author
|
@rubik: Done! I went ahead and amended the commit to add tests and I also changed the commit message to more closely resemble the existing commit messages in the project with the |
Owner
|
@msabramo Thanks for the contribution Marc, I will release a new version soon! |
Owner
|
@msabramo Done, I published version 5.1.0 and updated the changelog with your contributions. Thanks again! |
Contributor
Author
|
You're welcome, @rubik! Thanks for creating and open-sourcing this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: GH-182